[MVC 구현하기 - 2단계] 레넌(조형래) 미션 제출합니다. #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BETTERFUTURE4
approved these changes
Sep 27, 2022
| for (final Class<?> clazz : classes) { | ||
| private void addHandlerExecutions(final Map<Class<?>, Object> controllers) { | ||
| for (Class<?> clazz : controllers.keySet()) { | ||
| final Method[] methods = clazz.getDeclaredMethods(); | ||
| checkRequestMappingMethod(methods); | ||
| final Object controller = controllers.get(clazz); | ||
| checkRequestMappingMethod(controller, methods); |
There was a problem hiding this comment.
(그냥 의견입니다!)
해당 맵에서 각 세트마다 key, value 모두 사용하고 있네요.
keySet() 대신 entrySet()을 사용하는 방법도 있을 것 같아요.
물론 가독성 면에서 지금처럼 변수로 추출하는 것도 방법입니다. 트레이드 오프일 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 헌치~
이번에도 잘 부탁드려요~