[MVC 구현하기 - 3단계] 레넌(조형래) 미션 제출합니다. #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BETTERFUTURE4
suggested changes
Sep 29, 2022
Comment on lines
+28
to
+32
| model.put("hi", "hi"); | ||
| jsonView.render(model, request, response); | ||
|
|
||
| verify(writer).write("\"hi\""); | ||
| } |
There was a problem hiding this comment.
제가 이해한 레벨3 요구사항은
데이터가 1개일 때
verify(writer).write("{\"key\":\"value\"}"); 형태로,
데이터가 2개 이상일 땐
verify(writer).write("{\"obj1\":{}, \"obj2\":{}"); 형태로!
즉, Json의 기본 형태로 출력하는 뜻이지 않을까 생각했어요!
하지만 요구사항이 명확하게 설명되지 않은 면도 있고, 나만의 MVC를 구현하는 만큼 레넌이 구현한 방향도 가능할 것 같아요.😉
BETTERFUTURE4
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 헌치~
1,2 단계 리뷰 감사드려요
마지막 3단계도 잘 부탁드리겠습니다 !!