Skip to content

Commit 96594de

Browse files
committed
Add two accessible font sizes to Reader display settings
1 parent cc8921d commit 96594de

File tree

3 files changed

+25
-2
lines changed

3 files changed

+25
-2
lines changed

Modules/Sources/WordPressReader/Settings/ReaderDisplaySettings.swift

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -249,6 +249,8 @@ public struct ReaderDisplaySettings: Codable, Equatable, Hashable, Sendable {
249249
case normal
250250
case large
251251
case extraLarge
252+
case extraExtraLarge
253+
case extraExtraExtraLarge
252254

253255
public var scale: Double {
254256
switch self {
@@ -262,6 +264,10 @@ public struct ReaderDisplaySettings: Codable, Equatable, Hashable, Sendable {
262264
return 1.15
263265
case .extraLarge:
264266
return 1.25
267+
case .extraExtraLarge:
268+
return 1.4
269+
case .extraExtraExtraLarge:
270+
return 1.6
265271
}
266272
}
267273

@@ -297,6 +303,18 @@ public struct ReaderDisplaySettings: Codable, Equatable, Hashable, Sendable {
297303
value: "Extra Large",
298304
comment: "Accessibility label for the Extra Large size option, used in the Reader's reading preferences."
299305
)
306+
case .extraExtraLarge:
307+
return NSLocalizedString(
308+
"reader.preferences.size.extraExtraLarge",
309+
value: "Extra Extra Large",
310+
comment: "Accessibility label for the Extra Extra Large size option, used in the Reader's reading preferences."
311+
)
312+
case .extraExtraExtraLarge:
313+
return NSLocalizedString(
314+
"reader.preferences.size.extraExtraExtraLarge",
315+
value: "Extra Extra Extra Large",
316+
comment: "Accessibility label for the Extra Extra Extra Large size option, used in the Reader's reading preferences."
317+
)
300318
}
301319
}
302320

@@ -312,6 +330,10 @@ public struct ReaderDisplaySettings: Codable, Equatable, Hashable, Sendable {
312330
return "large"
313331
case .extraLarge:
314332
return "extra_large"
333+
case .extraExtraLarge:
334+
return "extra_extra_large"
335+
case .extraExtraExtraLarge:
336+
return "extra_extra_extra_large"
315337
}
316338
}
317339
}

RELEASE-NOTES.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
* [*] Add "File Size" to Site Media Details [#24947]
1313
* [*] Add "Email to Subscribers" row to "Publishing" sheet [#24946]
1414
* [*] Add permalink preview in the slug editor and make other improvements [#24949]
15+
* [*] Add two accessible font sizes to Reader display settings [#25013]
1516
* [*] Add "Taxonomies" to Site Settings [#24955]
1617
* [*] Update "Categories" picker to indicate multiple selection [#24952]
1718

WordPress/Classes/ViewRelated/Reader/Theme/ReaderDisplaySettingViewController.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ extension ReaderDisplaySettingSelectionView {
411411

412412
var sizeSelectionView: some View {
413413
Slider(value: $sliderValue,
414-
in: Double(ReaderDisplaySettings.Size.extraSmall.rawValue)...Double(ReaderDisplaySettings.Size.extraLarge.rawValue),
414+
in: Double(ReaderDisplaySettings.Size.extraSmall.rawValue)...Double(ReaderDisplaySettings.Size.extraExtraExtraLarge.rawValue),
415415
step: 1) {
416416
Text(Strings.sizeSliderLabel)
417417
} minimumValueLabel: {
@@ -420,7 +420,7 @@ extension ReaderDisplaySettingSelectionView {
420420
.accessibilityHidden(true)
421421
} maximumValueLabel: {
422422
Text("A")
423-
.font(Font(ReaderDisplaySettings.font(with: .sans, size: .extraLarge, textStyle: .body)))
423+
.font(Font(ReaderDisplaySettings.font(with: .sans, size: .extraExtraExtraLarge, textStyle: .body)))
424424
.accessibilityHidden(true)
425425
} onEditingChanged: { _ in
426426
let size = ReaderDisplaySettings.Size(rawValue: Int(sliderValue)) ?? .normal

0 commit comments

Comments
 (0)