-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto save doesn't work as expected for Jetpack sites Blocked by: Automattic/wp-calypso#20265 #11684
Comments
I tested 3 sites using WP Internal 12.4.0.20190506 on iPhone 6S iOS 12.2:
And I was able to successfully preview changes made to published posts in all three sites with both the Aztec editor and the block editor, however, the preview looks different depending on whether or not an update has been made to the post. (4m46s)
Possibly related: WordPress/gutenberg#13232 |
@designsimply , the Preview after making a change in your screen shot is a local preview created on the client. We are moving away from generating local preview as you can see here: #9282 Also, I think you might have tested this before I merged my PR. I think if you pull the latest develop and try again you should see a "remote preview" |
I tested with 12.4 beta, which definitely wouldn't have had your changes, which means I should be able to see the bug correct? (I believe what this tells us that it may be a bit tricky to replicate this bug and we should pay careful attention to the testing steps.) |
It shouldn't show the bug in 12.4 since we are not yet attempting to generate a remote preview there. |
Issue should be solved by the core patch. If so, will close after testing |
I agree, @aerych |
Closing as fixed :) Thanks @yaelirub! |
Reopening. While testing another issue I discovered I could no longer preview published posts on Jetpack test site. This was absolutely baffling. Various attempts to debug and reset the site's Jetpack connection were fruitless and it wasn't until I remembered having connected Jetpack via the app that I realized what had happened. As part of connecting and configuring Jetpack in the app I had been prompted to log in to the site in an in-app browser, so I was authenticated to the site when I recorded the demo. Today, with yesterday's auth cookie expired, I can see that previews are not working. :( Additionally, while testing in calypso in a browser I see that I'm prompted to log in to my site before editing a post, so this is something that is still not sorted out on the web (tho if SSO is enabled on the web the experience is somewhat better). Ugh. |
I have not been able to recreate this issue testing in 17.0. @startuptester @aerych can either of you reproduce this still? If not I think we can close it out again. |
This could have been resolved after recent changes on the web that move away from 3rd party cookies. Will follow up after I have a chance to test. |
Did a bit of testing and I was able to preview changes to drafts and to published posts. Closing. Thanks for taking a look @chipsnyder! |
This issue came up in code review for the implementation of Auto save published post upon preview and show preview url and will be visible in 12.5
We assume that something is not working correctly with the autosave endpoint for Jetpack sites. (possibly related to: Automattic/wp-calypso#20265)
Per @aerych's comment:
Expected behavior
When editing a published post and then choosing to preview it, the preview should show the post with the latest changes.
Actual behavior
For Jetpack sites, the post preview doesn't show the latest changes.
Steps to reproduce the behavior
Tested on [device], iOS [version], WPiOS [version]
SImulator iPhone Xs 12.2 and device iPhone 7 12.2
The text was updated successfully, but these errors were encountered: