Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto save doesn't work as expected for Jetpack sites Blocked by: Automattic/wp-calypso#20265 #11684

Closed
yaelirub opened this issue May 13, 2019 · 12 comments

Comments

@yaelirub
Copy link
Contributor

yaelirub commented May 13, 2019

This issue came up in code review for the implementation of Auto save published post upon preview and show preview url and will be visible in 12.5
We assume that something is not working correctly with the autosave endpoint for Jetpack sites. (possibly related to: Automattic/wp-calypso#20265)
Per @aerych's comment:

This time round when testing I included a self-hosted site connected via Jetpack. Previewing drafts seemed to work correctly but when previewing changes to an already published post the changes were not appearing for me in the preview. Not sure if this is a case were we need to include a force=wpcom parameter to query the cache site or if its just a limitation with this sort of site and we'd want to show the "no preview available" screen

Expected behavior

When editing a published post and then choosing to preview it, the preview should show the post with the latest changes.

Actual behavior

For Jetpack sites, the post preview doesn't show the latest changes.

Steps to reproduce the behavior

  1. Open a published post
  2. Make changes
  3. Tap preview
  4. See the post as published without changes
Tested on [device], iOS [version], WPiOS [version]

SImulator iPhone Xs 12.2 and device iPhone 7 12.2

@designsimply
Copy link
Contributor

designsimply commented May 13, 2019

I tested 3 sites using WP Internal 12.4.0.20190506 on iPhone 6S iOS 12.2:

  • WP 5.2 Jetpack 7.3.0 architectural-worm.jurassic.ninja
  • WP 5.1.1 Jetpack 7.2.1 serious-snake.jurassic.ninja
  • WP 5.2 Self-hosted open-bear.jurassic.ninja

And I was able to successfully preview changes made to published posts in all three sites with both the Aztec editor and the block editor, however, the preview looks different depending on whether or not an update has been made to the post. (4m46s)

Preview before making a change Preview after making a change
preview-before-update preview-after-update

Possibly related: WordPress/gutenberg#13232

@yaelirub
Copy link
Contributor Author

@designsimply , the Preview after making a change in your screen shot is a local preview created on the client. We are moving away from generating local preview as you can see here: #9282

Also, I think you might have tested this before I merged my PR. I think if you pull the latest develop and try again you should see a "remote preview"

@designsimply
Copy link
Contributor

I tested with 12.4 beta, which definitely wouldn't have had your changes, which means I should be able to see the bug correct? (I believe what this tells us that it may be a bit tricky to replicate this bug and we should pay careful attention to the testing steps.)

@yaelirub
Copy link
Contributor Author

It shouldn't show the bug in 12.4 since we are not yet attempting to generate a remote preview there.
Your comments make me realize that I should have mentioned more clearly that this will become a production issue in 12.5

@yaelirub yaelirub added the [Status] Blocked Waiting for a different task to be able to proceed label Jun 25, 2019
@yaelirub yaelirub changed the title Auto save doesn't work as expected for Jetpack sites Auto save doesn't work as expected for Jetpack sites Blocked by: https://github.com/Automattic/wp-calypso/issues/20265 Jun 25, 2019
@yaelirub yaelirub changed the title Auto save doesn't work as expected for Jetpack sites Blocked by: https://github.com/Automattic/wp-calypso/issues/20265 Auto save doesn't work as expected for Jetpack sites Blocked by: Automattic/wp-calypso#20265 Jun 25, 2019
@yaelirub
Copy link
Contributor Author

Issue should be solved by the core patch. If so, will close after testing

@yaelirub yaelirub removed the [Status] Blocked Waiting for a different task to be able to proceed label Sep 27, 2019
@aerych
Copy link
Member

aerych commented Oct 7, 2020

I took a look at this issue today and it looks like it might be resolved. See the attached demo.
Screen Recording 2020-10-06 at 3 56 35 PM 2020-10-06 22_07_23
What do you think?

@yaelirub
Copy link
Contributor Author

yaelirub commented Oct 7, 2020

I agree, @aerych

@aerych
Copy link
Member

aerych commented Oct 7, 2020

Closing as fixed :) Thanks @yaelirub!

@aerych aerych closed this as completed Oct 7, 2020
@aerych
Copy link
Member

aerych commented Oct 7, 2020

Reopening.

While testing another issue I discovered I could no longer preview published posts on Jetpack test site. This was absolutely baffling. Various attempts to debug and reset the site's Jetpack connection were fruitless and it wasn't until I remembered having connected Jetpack via the app that I realized what had happened. As part of connecting and configuring Jetpack in the app I had been prompted to log in to the site in an in-app browser, so I was authenticated to the site when I recorded the demo. Today, with yesterday's auth cookie expired, I can see that previews are not working. :(

Additionally, while testing in calypso in a browser I see that I'm prompted to log in to my site before editing a post, so this is something that is still not sorted out on the web (tho if SSO is enabled on the web the experience is somewhat better).

Ugh.

@aerych aerych reopened this Oct 7, 2020
@chipsnyder
Copy link
Contributor

I have not been able to recreate this issue testing in 17.0.

@startuptester @aerych can either of you reproduce this still? If not I think we can close it out again.

@aerych
Copy link
Member

aerych commented Mar 29, 2021

This could have been resolved after recent changes on the web that move away from 3rd party cookies. Will follow up after I have a chance to test.

@aerych
Copy link
Member

aerych commented Mar 30, 2021

Did a bit of testing and I was able to preview changes to drafts and to published posts. Closing. Thanks for taking a look @chipsnyder!

@aerych aerych closed this as completed Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants