Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media & Text block needs update with new prop names of MediaPlaceholder and MediaUpload #1338

Closed
pinarol opened this issue Aug 30, 2019 · 5 comments
Closed

Media & Text block needs update with new prop names of MediaPlaceholder and MediaUpload #1338

pinarol opened this issue Aug 30, 2019 · 5 comments

Comments

@pinarol
Copy link
Contributor

pinarol commented Aug 30, 2019 •
edited
Loading

Media & Text block is merged to rnmobile/master recently but since it is merged at the same time with unify props PR it missed to use the new prop names. We need a small PR to fix Media & Text block to use new prop names of MediaUpload & MediaPlaceholder.
@pinarol
Copy link
Contributor Author

pinarol commented Aug 30, 2019

Could someone do a quick PR for this? @dratwas @lukewalczak ?

@pinarol
Copy link
Contributor Author

pinarol commented Aug 30, 2019

cc @geriux : You might find Media & Text block is not working on the latest rnmobile/master

@lukewalczak
Copy link
Contributor

Will handle it!

@lukewalczak
Copy link
Contributor

PR is ready.

@pinarol
Copy link
Contributor Author

pinarol commented Sep 6, 2019

Merged WordPress/gutenberg#17268

@pinarol pinarol closed this as completed Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pinarol @lukewalczak