Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SPTs(Layouts) public #1962

Closed
pinarol opened this issue Feb 27, 2020 · 6 comments · Fixed by WordPress/gutenberg#20718 or #1987
Closed

Make SPTs(Layouts) public #1962

pinarol opened this issue Feb 27, 2020 · 6 comments · Fixed by WordPress/gutenberg#20718 or #1987
Assignees
Labels
good first issue Good for newcomers Page Templates [Type] Enhancement Improves a current area of the editor

Comments

@pinarol
Copy link
Contributor

pinarol commented Feb 27, 2020

Let's remove the feature flag and open SPTs(Layouts) for public usage.

@pinarol pinarol added [Type] Enhancement Improves a current area of the editor good first issue Good for newcomers Page Templates labels Feb 27, 2020
@pinarol
Copy link
Contributor Author

pinarol commented Feb 27, 2020

After the completion of SPTs metrics, it seems like we are ready to do this. Let me know if you have any concerns. @koke @iamthomasbishop

@koke
Copy link
Member

koke commented Feb 27, 2020

I think it's good to go 😊

@iamthomasbishop
Copy link
Contributor

I'm not 100% sure what "make public" means in this case, but assuming it's just removing the DEV flag so we can test internally, I think that's a 👍 from me. To be clear, I need to do a more comprehensive design review now that we are ready to test all of the individual pieces together, but if that's all correct then 👍 from me!

@pinarol
Copy link
Contributor Author

pinarol commented Mar 8, 2020

but assuming it's just removing the DEV flag so we can test internally

Right, we'll remove the DEV flag, thus, you'll be able to test. Once we merge this change it'll be available in prod so, we'll need your review/approval on the PR. @iamthomasbishop

@iamthomasbishop
Copy link
Contributor

Perfect! Let’s do it :shipit:

@koke
Copy link
Member

koke commented Mar 9, 2020

I’ll take it. I started this last week so I could get CircleCI to generate an installable build, so most of it is done, it just needs PRs to be created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Page Templates [Type] Enhancement Improves a current area of the editor
Projects
None yet
3 participants