Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve footer copy on color picker BottomSheet #3766

Closed
iamthomasbishop opened this issue Jul 28, 2021 · 1 comment · Fixed by WordPress/gutenberg#33973 or #3817
Closed

Improve footer copy on color picker BottomSheet #3766

iamthomasbishop opened this issue Jul 28, 2021 · 1 comment · Fixed by WordPress/gutenberg#33973 or #3817
Assignees
Labels
[Type] Bug Something isn't working

Comments

@iamthomasbishop
Copy link
Contributor

Describe the bug

We've heard that some users assume that the "Select a color" label is an action button. I believe we should phrase this slightly more clearly and potentially change what is displayed depending on whether or not the user has a color selected.

To Reproduce

Steps to reproduce the behavior:

  1. Add any block that supports colors (paragraph, button, group, etc)
  2. Open the block's settings by tapping on the settings/cog icon near the block's content
  3. Tap on one of the color setting cells (i.e. text color or background color)
  4. Notice that the footer of the BottomSheet has a text label that says "Select a color" (this is where the confusion arises)

Proposed solution(s)

I propose that we change the label to “Select a color above” (other options considered were "Select color above", "No color selected"). This should be a bit clearer, as it directs users to the color-selection control.

We're also not displaying the selected color's hex value (like we are on the "custom color" picker — in monospace font and the ability to long-press to copy the associated hex value) when the user has a color selected, but it would be good to do so; both for consistency and visibility.

Here's an overview of the interaction:

image

@enejb
Copy link
Contributor

enejb commented Aug 17, 2021

Great work! I think this makes things cleared.

I wonder if we should display the value next to the colour and if the user clicks on it we can copy it to the clip board. With a little copied tooltip.

And if a user has a colour in the clipboard we could make the copied colour as of the colour that is available to be selected. (maybe even the first one)

I think that would help address some of the issues faced in #3775 issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
3 participants