Link picker bottomsheet screen navigations are not transitioning properly

[mkevins]

Describe the bug
The transition between bottomsheet screens in the link picker are no longer transitioning smoothly, and in some cases, the UI is left in an unusable state.

To Reproduce
Steps to reproduce the behavior:

1. In a new post add some text to a paragraph block
2. Select that text and tap the link button on the format bar
3. Tap to search for a post or page to link to (expect to enter a fullscreen search picker)
4. Enter some text and pick pick a post or page from the results (expect to return to the non-fullscreen link settings screen)
5. Tap the URL to edit it or search for another post / page (expect to enter the fullscreen picker again)
6. Tap "Cancel" (ios) or "X" (Android) to close the search screen (expect to return to the non-fullscreen link settings screen)

Expected behavior
The transitions between these screens should be smooth, and should not result in janky behavior.

Actual behavior:

Sometimes the keyboard slides up and down after returning to the main link settings screen (observed on iOS)

keyboard-glitch-ios.mov

Sometimes the fullscreen search screen is does not render properly, and the former settings screen is displayed on top of the search screen in a semi-transparent way. See below (note the blinking caret):

subscreen-bug-android.mp4

Smartphones:

• Devices: iPhone 11 (14.7.1), Pixel 3a (Android 11)

Additional context
Add any other context about the problem here.

[dcalhoun]

I looked into this a bit today, and wanted to share my findings thus far. The issues here do not appear related to the recent inserter search changes in WordPress/gutenberg#34129.

I was unable to replicate the semi-transparent double screen Android issue. However, I was able to identify that the animations when closing the bottom sheet were removed for Android in WordPress/gutenberg#28632. Reintroducing the layout conditional appears to fix this. I can open a PR for that later.

For iOS, it appears a toggling of the keyboard's visibility status from Hide to Show to Hide causes the animation stutter. Applying Android's keyboard dismissal and delayed navigation appears to resolve this. I can also open a PR for this later.

[mkevins]

Thanks @dcalhoun for such a quick response to this! 🎉

However, I was able to identify that the animations when closing the bottom sheet were removed for Android in WordPress/gutenberg#28632. Reintroducing the layout conditional appears to fix this. I can open a PR for that later.

For iOS, it appears a toggling of the keyboard's visibility status from Hide to Show to Hide causes the animation stutter. Applying Android's keyboard dismissal and delayed navigation appears to resolve this. I can also open a PR for this later.

I'll check out those PRs 👍

[dcalhoun]

I am removing my assignment for the time being, as I do not plan to work on this in the near future.

Whenever we re-engage this work, we should be sure to test #3894 (comment) and #3894 (comment). Additionally, this bug may eventually relate to work on WordPress/gutenberg#37559.