Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Embed block] Add integration tests #4086

Closed
18 tasks done
Tracked by #3288
fluiddot opened this issue Oct 7, 2021 · 4 comments · Fixed by #4199
Closed
18 tasks done
Tracked by #3288

[Embed block] Add integration tests #4086

fluiddot opened this issue Oct 7, 2021 · 4 comments · Fixed by #4199

Comments

@fluiddot
Copy link
Contributor

fluiddot commented Oct 7, 2021

Description

The integration tests should cover all the user flows implemented for the block:

@fluiddot
Copy link
Contributor Author

@jd-alexander heads up that I appended more cases that we initially didn't cover.

@jd-alexander
Copy link
Contributor

@jd-alexander heads up that I appended more cases that we initially didn't cover.

Thanks for doing that! 🙇🏾

@hypest
Copy link
Contributor

hypest commented Nov 2, 2021

👋 all, I notice that the subcases listed in the description are all marked as "checked" at this point. Does this mean we can close this ticket as "done"? WDYT @fluiddot ?

@fluiddot
Copy link
Contributor Author

fluiddot commented Nov 2, 2021

👋 all, I notice that the subcases listed in the description are all marked as "checked" at this point. Does this mean we can close this ticket as "done"? WDYT @fluiddot ?

I was thinking to close it automatically when the PR that introduces the integration tests is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants