Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Tiled Gallery's Link To implementation #4156

Closed
guarani opened this issue Oct 25, 2021 · 2 comments
Closed

Jetpack Tiled Gallery's Link To implementation #4156

guarani opened this issue Oct 25, 2021 · 2 comments
Labels
Tiled Gallery block Issues with this label will automatically appear on the project's board [Type] Enhancement Improves a current area of the editor

Comments

@guarani
Copy link
Contributor

guarani commented Oct 25, 2021

In #4136 (comment), it was concluded that the Jetpack Tiled Gallery's "Link To" functionality (found in its settings bottom sheet) should be implemented to match the web's link to options ("Media File" and "Attachment Page"). These options apply at a gallery-level (i.e. link to functionality won't be found in individual blocks, but instead at the parent block level).

At time of writing, the UI of these options is being developed for other blocks (see WordPress/gutenberg#34846). Given this, we also decided that the Tiled Gallery can be shipped without the "Link To" functionality and this can be added later (hence this issue stands to capture that requirement).

For reference, this is what the options should do:

  • Media File: This makes the gallery's images clickable. Clicking the images opens a direct link to the image's underlying media file.
  • Attachment Page: This also makes the gallery's images clickable, but instead clicking results in a carousel (or other theme-specific) attachment page to be shown.

For reference, the Image block's settings are implemented here.

@guarani guarani added the Tiled Gallery block Issues with this label will automatically appear on the project's board label Oct 25, 2021
@guarani guarani changed the title Jetpack Tiled Gallery's link to implementation Jetpack Tiled Gallery's Link To implementation Oct 25, 2021
@mchowning mchowning added the [Type] Enhancement Improves a current area of the editor label Oct 26, 2021
@mchowning
Copy link
Contributor

I'm not really sure whether the Enhancement label makes sense here. Feel free to remove/replace it.

@guarani
Copy link
Contributor Author

guarani commented Oct 28, 2021

I'm not really sure whether the Enhancement label makes sense here. Feel free to remove/replace it.

I like this idea because easily filtering a project's issues vs bugs seems useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tiled Gallery block Issues with this label will automatically appear on the project's board [Type] Enhancement Improves a current area of the editor
Projects
Status: Done (keep clean, manually)
Development

No branches or pull requests

3 participants