Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPAndroid] Wire up media handling with GutenbergEditorFragment and GutenbergEditPostActivity #459

Closed
2 tasks
mzorz opened this issue Dec 28, 2018 · 1 comment

Comments

@mzorz
Copy link
Contributor

mzorz commented Dec 28, 2018

Comes from wordpress-mobile/WordPress-Android#8874

As part of the work being done inhttps://github.com/wordpress-mobile/WordPress-Android/pull/8874 to introduce a dedicated GutenbergEditPostActivity , and when after the merge and introduction of media uploads in wordpress-mobile/WordPress-Android#8879, #458 and WordPress/gutenberg#13128 happens, we'll need to rewire great part of the code to handle fail, async progress reattachment, and PostModel media relationships cleanup on opening / closing of the editor.

Tracking the tasks here

Media - related ToDo

  • adapt purgeMediaToPostAssociationsIfNotInPostAnymore to work on Gutenberg contents.
  • re-wire media upload reattach/progress/failed/purge/delete mechanisms once media upload is in place in Gutenberg

I'll add more tasks to this list when the time comes to tackle this one. In the meantime, all code that has been assessed as needed (even potentially) to re-wire was commented out and annotated with a // TODO for further checking in from wordpress-mobile/WordPress-Android#8874

@mzorz
Copy link
Contributor Author

mzorz commented Jan 28, 2019

Closing this, not valid anymore as per wordpress-mobile/WordPress-Android#8874 (comment)

@mzorz mzorz closed this as completed Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant