Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom Sheet / Image Settings Visual Refinements #535

Closed
5 tasks done
iamthomasbishop opened this issue Feb 4, 2019 · 1 comment
Closed
5 tasks done

Bottom Sheet / Image Settings Visual Refinements #535

iamthomasbishop opened this issue Feb 4, 2019 · 1 comment
Assignees

Comments

@iamthomasbishop
Copy link
Contributor

iamthomasbishop commented Feb 4, 2019

Per discussion with @etoledom regarding our progress on the updated "neutral" Bottom Sheets that will be housing Image Block Settings, I wanted to jot down some notes regarding recommended visual refinements. But first, some useful context:

Related Issues

Current State

Here's a screenshot of what the current developed state looks like:

screen shot 2019-02-04 at 1 09 04 pm

Proposed Design

Here's the proposed design – nearly identical to what @etoledom has here 👏

image

Proposed Refinements to Dev

  • Remove the : from “Link To”. (in-progress)
  • Force title case for the row titles (Link To, Alt Text, CSS Class, etc). (This is a point of difference between HIG and Material, but I’d prefer to use title case.)
  • Truncate long text strings in the middle instead of at the end of the line.
  • Make last row’s border-bottom full-width.
  • 24pt margin between the top of sheet and start of the table. (example)
@etoledom
Copy link
Contributor

Closed via WordPress/gutenberg#13855

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants