Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard automatically resigns and becomes active in an infinite loop #6002

Closed
kean opened this issue Jul 27, 2023 · 6 comments · Fixed by WordPress/gutenberg#53217
Closed
Assignees
Labels
[Pri] High [Type] Bug Something isn't working

Comments

@kean
Copy link

kean commented Jul 27, 2023

Describe the bug
Keyboard automatically resigns and becomes active in an infinite loop without any user interactions.

To Reproduce
Steps to reproduce the behavior:

Can't provide these. I've been simply adding one block type after another to monitor the memory usage. At some point, I saw two "Start typing..." blocks at the bottom and the keyboard started doing it.

Expected behavior
n/a

Screenshots

RPReplay_Final1690480652.mp4

Smartphone (please complete the following information):

Additional context
Add any other context about the problem here.

@kean kean added the [Type] Bug Something isn't working label Jul 27, 2023
@kean
Copy link
Author

kean commented Jul 27, 2023

I managed to stop it be pressing (+) a few times.

@kean
Copy link
Author

kean commented Jul 27, 2023

I was able to reproduce it again without doing anything special. I was just adding more blocks.

Here are some more videos to demonstrate what's happening. I'm not performing any interactions. I managed to close it
and save the draft, but only after some struggle because the confirmation alert also kept jumping up and down.

https://github.com/wordpress-mobile/gutenberg-mobile/assets/1567433/f28edeae-5aeb-4725-afc4-372e0b25711b
https://github.com/wordpress-mobile/gutenberg-mobile/assets/1567433/7755997b-c3b6-449c-ac69-eb8bb5bc994e

@twstokes
Copy link
Contributor

Thanks @kean for reporting this!

It would be worth us testing on or after 1614edc where we merged the React Native upgrade to see if anything acts differently. 🤔

@geriux geriux self-assigned this Jul 31, 2023
@geriux
Copy link
Contributor

geriux commented Jul 31, 2023

Hey @kean 👋 we are currently working on a fix for this, would you mind testing this build when you have a chance to see if it fixes it for you? Any feedback would be appreciated, thank you!

@kean
Copy link
Author

kean commented Jul 31, 2023

Hey @geriux, thanks for addressing it so quickly. I tested it, and after adding hundreds of blocks, it's still going strong with no issues. It feels snappier too; maybe it's just me.


Unrelated:

  • It would be nice to entirely eliminate the keyboard jumps when adding new paragraphs
  • "Start writing..." placeholders looks like regular text; it would be nice to make them gray

@geriux
Copy link
Contributor

geriux commented Aug 1, 2023

Thank you for testing! Happy to see that it fixed the issue for you! And that it feels snappier 🎉

It would be nice to entirely eliminate the keyboard jumps when adding new paragraphs
"Start writing..." placeholders looks like regular text; it would be nice to make them gray

Those are great suggestions!

Hopefully, we'll be able to avoid hiding/showing the Keyboard in the future when we improve the current implementation we have with Aztec.

As for the placeholder, I'll create an issue to track it. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] High [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants