Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve resolving of ' In-use by subscription(s)' RT using dataloaders #703

Open
DutchBen opened this issue Apr 18, 2024 · 1 comment
Open

Comments

@DutchBen
Copy link
Contributor

DutchBen commented Apr 18, 2024

When displaying the 'In-use by subscription(s)' on the subscription detail page we use the json value from that field to make a graphql call to resolve them to name, description and product name.
See:
rtk/endpoints/subscriptionDetail.ts
rtk/endpoints/subscriptionInUseByRelationQuery.ts
components/WfoSubscription/WfoInUseByRelations.tsx

This could be improved if the backend resolves the field subscriptiondetail >> producBlockInstances >> inUseByRelations with these fields instead of a json object as it is now.

@Georgi2704
Copy link
Collaborator

Also discussed that about the productBlockInstances with @mrijk
similarly. issue:workfloworchestrator/orchestrator-ui-library#782

There could be a resolver for the Owner Subscription Description for a product block, not sure if it should be part of this specific issue.

@wouter1975 wouter1975 changed the title Improve resolving of ' In-use by subscription(s)' Improve resolving of ' In-use by subscription(s)' RT using dataloaders Jul 8, 2024
@wouter1975 wouter1975 transferred this issue from workfloworchestrator/orchestrator-ui-library Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants