Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Process detail page does not update with a callback_step in ThreadPool Executor #744

Open
tjeerddie opened this issue Sep 26, 2024 · 0 comments
Labels
bug Something isn't working triage Issue that need to be triaged

Comments

@tjeerddie
Copy link
Contributor

tjeerddie commented Sep 26, 2024

This issue was addressed in frontend workfloworchestrator/orchestrator-ui-library#1456 and after looking into it we found out that it is a backend issue.

Mahammad@Geant reports that the process detail page doens't update throught the websocket connection when there are callback steps in his form. The websocket connection is established and the backend sends the correct cache invalidation requests, it appears to stop doing that when a callback step is reached.

When using the ThreadPool executor, the callback_step does not send a websocket message to the frontend for the validation step. The frontend does not update and you don't see that it has failed until refreshing.

I have not been able to reproduce the problem inside Celery executor, so I would assume the problem has to do with ProcessDataBroadcastThread.

steps to reproduce

  1. create a workflow with a callback_step
  2. run the workflow and make sure that the validation step in the callback_step raises an error.
  3. see that the frontend does not receive a websocket message to update the process detail page data.

Version

2.7.5

What python version are you seeing the problem on?

No response

Relevant log output

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Issue that need to be triaged
Projects
None yet
Development

No branches or pull requests

1 participant