Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subscription note editor showing old value when pressing Cancel in NMS #1551

Open
Georgi2704 opened this issue Nov 11, 2024 · 1 comment
Assignees
Labels
Backend bug Something isn't working

Comments

@Georgi2704
Copy link
Contributor

Georgi2704 commented Nov 11, 2024

How to reproduce:
Saving the new note of a subscription. Open again the note editor and cancel the editing. The old value (before saving) of the note will appear again.

In subscription detail general tab the problem doesn't seem to happen because the subscription is invalidated an and the new data is fetched after running the modify note workflow. So when clicking cancel the initalValue of the editor already has the new value loaded.

Screenshot 2024-11-11 at 15 47 37
Screenshot 2024-11-11 at 15 47 49

Solution:

  • apply websocket to the page
@Georgi2704 Georgi2704 added the bug Something isn't working label Nov 11, 2024
@Georgi2704
Copy link
Contributor Author

Maybe a websocket cache invalidation when the modify_note_workflow is finished ?
@DutchBen

@wouter1975 wouter1975 added the _to discuss to discuss label Nov 13, 2024
@wouter1975 wouter1975 added Backend and removed _to discuss to discuss labels Nov 21, 2024
@wouter1975 wouter1975 self-assigned this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants