feat(gantt): support gantt table body dragStarted dragEnded function(#INFR-7138) #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walkerkay
reviewed
Apr 3, 2023
| @@ -12,6 +12,10 @@ export class NgxGanttTableComponent { | |||
|
|
|||
| @Output() dragDropped = new EventEmitter<GanttTableDragDroppedEvent>(); | |||
|
|
|||
| @Output() dragStarted = new EventEmitter<GanttItemInternal>(); | |||
There was a problem hiding this comment.
Event 不能直接用 GanttItemInternal，未来没法扩展了，需要跟其他的 Event 一样 定义一个 GanttTableDragStartedEvent 和 GanttTableDragEndedEvent
interface GanttTableDragStartedEvent {
source: GanttItem;
sourceParent: GanttItem;
}
walkerkay
reviewed
Apr 3, 2023
| sourceParent: GanttItem<T>; | ||
| } | ||
|
|
||
| export class GanttTableDragEndedEvent<T = unknown> { |
There was a problem hiding this comment.
GanttTableDragEndedEvent 的属性应该跟 Started 一样 只有 source 和 parent， 只有 Dropped 的时候才会有 target，比如刚拖起来就放下，这种都不会触发Dropped的，但是会触发 Ended
walkerkay
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.