fix(gantt): the fast right (left) dragging start (end) time, the width of the bar is wrong #INFR-7111 #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h of bar is wrong #INFR-7111
…h of bar is wrong #INFR-7111
| @@ -376,9 +378,16 @@ export class GanttBarDrag implements OnDestroy { | |||
|
|
|||
| this.item.updateDate(start, this.item.end); | |||
| } else { | |||
| if (this.flagDays > 0 && days <= 0) { | |||
There was a problem hiding this comment.
if (this.flagDays > 0 && days <= 0) { 这个判断有点多余，直接去掉这样处理也没问题
There was a problem hiding this comment.
我们只需要在days第一次变成负数之后执行style修改。
如果没有这个判断的话，只要时间条一直往反方向拖(开始大于截止或截止小于开始)，days就会一直是<0，就会不断进来执行这段style修改，不好。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.