fix: fix misalignment when scrollbar scrolls to the edge #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ark-65
force-pushed
the
ark/fix-scrollbar-2
branch
from
f3bc8f1
to
0756e16
Compare
ark-65
force-pushed
the
ark/fix-scrollbar-2
branch
from
7ae3d52
to
f865ec3
Compare
HandsomeButterball
requested changes
Jul 4, 2023
packages/gantt/src/root.component.ts
Outdated
| @@ -80,6 +91,23 @@ export class NgxGanttRootComponent implements OnInit, OnDestroy { | |||
| }); | |||
| } | |||
|
|
|||
| ngAfterViewInit() { | |||
| setTimeout(() => { | |||
| this.updateScrollBarOffset(); | |||
There was a problem hiding this comment.
这个方法的调用放到上面 this.dom.initialize(this.elementRef); 这里下面，这个是有一定是能获取到 mainContainer 的
packages/gantt/src/root.component.ts
Outdated
| updateScrollBarOffset() { | ||
| if (this.mainTemplate?.elementRef) { | ||
| const ganttMainContainer = | ||
| this.mainTemplate.elementRef.nativeElement.previousElementSibling.querySelector('.gantt-main').firstChild; |
There was a problem hiding this comment.
这里不用这样获取，直接 this.dom.mainContainer 就能获取到，上面的判断也不需要
| @@ -235,6 +249,16 @@ export class NgxGanttComponent extends GanttUpper implements OnInit, OnChanges, | |||
| this.viewportItems = [...this.viewportItems]; | |||
| } | |||
|
|
|||
| private updateScrollBarOffset() { | |||
There was a problem hiding this comment.
这里不需要重新算一遍，直接拿 root 里的就行
| @@ -2,7 +2,7 @@ | |||
| <div class="gantt-header"> | |||
| <gantt-table-header #tableHeader [columns]="columns"></gantt-table-header> | |||
| <div class="gantt-container-header"> | |||
| <gantt-calendar-header></gantt-calendar-header> | |||
| <gantt-calendar-header [style.padding-right.px]="verticalScrollbarWidth"></gantt-calendar-header> | |||
There was a problem hiding this comment.
下面说了不用再在 gantt 组件里计算滚动条了直接用 [style.padding-right.px]="ganttRoot.verticalScrollbarWidth" 就可以
ark-65
force-pushed
the
ark/fix-scrollbar-2
branch
from
f326282
to
b8531a0
Compare
HandsomeButterball
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.