feat: support custom header and item height #431 #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walkerkay
reviewed
Mar 13, 2024
| @@ -1,6 +1,6 @@ | |||
| <ngx-gantt-root [sideWidth]="300"> | |||
| <ng-template #sideTemplate> | |||
| <div class="gantt-flat-side-header">项目</div> | |||
| <div class="gantt-flat-side-header" [style.height.px]="styles.headerHeight" [style.line-height.px]="styles.headerHeight">项目</div> | |||
| @@ -10,7 +10,7 @@ | |||
| [class.weekend]="point.additions?.isWeekend" | |||
| *ngFor="let point of view.primaryDatePoints; trackBy: trackBy" | |||
| [attr.x]="point.x" | |||
| [attr.y]="point.y" | |||
| [attr.y]="primaryDatePointTop" | |||
There was a problem hiding this comment.
这个 y 的计算在视图里头，尽量在视图中去计算这个 y 值，而不是在组件内去计算，不同的视图 y 的规则可能是不一样的
There was a problem hiding this comment.
这个 y 的计算在视图里头，尽量在视图中去计算这个 y 值，而不是在组件内去计算，不同的视图 y 的规则可能是不一样的
可以在创建 view的时候，把需要的 height 传入进去，这样内部就可以计算 y 值了
| @@ -11,14 +11,11 @@ order: 50 | |||
| @use '@worktile/gantt/styles/variables.scss' with ( | |||
| // basic | |||
| $gantt-color: #333, | |||
| $gantt-header-height: 44px, | |||
| $gantt-border-color: #eee, | |||
| $gantt-bg-color: #fff, | |||
| $gantt-side-shadow: 12px 0 16px -10px rgba(0, 0, 0, 0.15), | |||
| $gantt-container-background-color: #fafafa, | |||
There was a problem hiding this comment.
直接去掉这些变量的话，不知道之前用到这些变量的应用会不会收到影响，得确认下
walkerkay
approved these changes
Mar 14, 2024
walkerkay
approved these changes
Mar 15, 2024
walkerkay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.