Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add stop function to planet service #117

Merged
merged 2 commits into from
Jul 30, 2020
Merged

fix: add stop function to planet service #117

merged 2 commits into from
Jul 30, 2020

Conversation

mario-mui
Copy link
Contributor

No description provided.

@why520crazy
Copy link
Member

Perfect，good issue for your contribution.

Please add some unit test?

@mario-mui
Copy link
Contributor Author

Perfect，good issue for your contribution.

Please add some unit test?

had add stop unit test

@why520crazy
Copy link
Member

test this please

@why520crazy why520crazy reopened this Jul 30, 2020
@why520crazy why520crazy merged commit eb9c93a into worktile:master Jul 30, 2020
@why520crazy
Copy link
Member

please bump @worktile/planet to 1.2.0

@why520crazy
Copy link
Member

@all-contributors please add @Mario56 for code

@allcontributors allcontributors bot mentioned this pull request Jul 30, 2020
Merged
@allcontributors
Copy link
Contributor

@why520crazy

I've put up a pull request to add @Mario56! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mario-mui @why520crazy