Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iegitaddmd] - no README in .git folder #229

Closed
kbjarkefur opened this issue May 1, 2020 · 5 comments
Closed

[iegitaddmd] - no README in .git folder #229

kbjarkefur opened this issue May 1, 2020 · 5 comments
Assignees
Labels
minor bug Bug unlikely to lead to incorrect analysis resolved but not yet published Issue is fixed, but not yet published on SSC

Comments

@kbjarkefur
Copy link
Contributor

kbjarkefur commented May 1, 2020

iegitadd should ignore .git folder.

Putput submitted by @bbdaniels :

You are about to create a file [README.md] in the folder [/Users/username/GitHub/eq-kids/.git/objects/info].
@kbjarkefur kbjarkefur added the minor bug Bug unlikely to lead to incorrect analysis label May 1, 2020
@kbjarkefur kbjarkefur self-assigned this May 1, 2020
@bbdaniels
Copy link
Contributor

Easiest is to ignore any invisible folder I think? On MacOS this is done just by skipping any folder whose name starts with .

@kbjarkefur
Copy link
Contributor Author

.git folder should be ignored by default, that is straightforward.

I think it is too broad to ignore all folders starting on . as default. But it would be great feaster.

I am thinking an skipfolder() option where you list folder names to be ignored. .git is the only default value.

What do you think?

@bbdaniels
Copy link
Contributor

That's a good idea, is it possible to make it work with wildcards so I can do like skip(.*) etc?

@kbjarkefur
Copy link
Contributor Author

Possible, yes. Worth implementing for this fix, not sure.

It can be put on the wish list as a utility function. And once we have that we can apply it here too. But for now I will probably implement without wildcards.

@kbjarkefur
Copy link
Contributor Author

Suggested solution in #230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor bug Bug unlikely to lead to incorrect analysis resolved but not yet published Issue is fixed, but not yet published on SSC
Projects
None yet
Development

No branches or pull requests

2 participants