You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PRs like #3955 could be avoided if a test enforced that there is chain ID parity between the SDK and the generated proto go files. It is already enforced that what the proto files generate match what is committed. This seems like the next logical step.
Definition of done
Changing the chains in sdk/vaa/structs.go requires changing them in proto/publicrpc/v1/publicrpc.proto (and vice-versa), enforced via a go test or CI check.
The text was updated successfully, but these errors were encountered:
Description and context
PRs like #3955 could be avoided if a test enforced that there is chain ID parity between the SDK and the generated proto go files. It is already enforced that what the proto files generate match what is committed. This seems like the next logical step.
Definition of done
Changing the chains in
sdk/vaa/structs.go
requires changing them inproto/publicrpc/v1/publicrpc.proto
(and vice-versa), enforced via a go test or CI check.The text was updated successfully, but these errors were encountered: