Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce proto and go sdk chain IDs are in sync via a test #3956

Open
evan-gray opened this issue May 28, 2024 · 0 comments
Open

Enforce proto and go sdk chain IDs are in sync via a test #3956

evan-gray opened this issue May 28, 2024 · 0 comments

Comments

@evan-gray
Copy link
Contributor

Description and context

PRs like #3955 could be avoided if a test enforced that there is chain ID parity between the SDK and the generated proto go files. It is already enforced that what the proto files generate match what is committed. This seems like the next logical step.

Definition of done

Changing the chains in sdk/vaa/structs.go requires changing them in proto/publicrpc/v1/publicrpc.proto (and vice-versa), enforced via a go test or CI check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant