Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance EVM Test Suite #4090

Open
gator-boi opened this issue Aug 20, 2024 · 1 comment
Open

Enhance EVM Test Suite #4090

gator-boi opened this issue Aug 20, 2024 · 1 comment

Comments

@gator-boi
Copy link
Contributor

gator-boi commented Aug 20, 2024

I reviewed the ethereum directory. The tests in this PR are meant to replicate the existing javascript tests. However, these tests need a lot of work and there should be a follow up PR that fixes these tests (and adds a more comprehensive test suite). Here is a short list of enhancements we could add to improve the test suite:

  • Splitting out tests into positive and negative tests. Currently, a lot of the revert statements are triggered in the same test that evaluate happy path logic.
  • Changing the test names (and add a comment for each test describing what the test does). Some of the test names are insanely long and are difficult to read.
  • Adding helper functions for payload generation. For example, the Bridge tests could use a method that generates a token transfer payload given some common inputs.
  • Write helper functions to set up certain testing scenarios rather than calling other tests internally.
  • Use the wormhole interfaces in the tests instead of duplicating events, and constants.
  • Fuzz testing

Originally posted by @gator-boi in #4070 (review)

@evan-gray
Copy link
Contributor

Resolved the comments in #4070, but I expect that all of them should be addressed along with this issue as @gator-boi described.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants