You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I reviewed the ethereum directory. The tests in this PR are meant to replicate the existing javascript tests. However, these tests need a lot of work and there should be a follow up PR that fixes these tests (and adds a more comprehensive test suite). Here is a short list of enhancements we could add to improve the test suite:
Splitting out tests into positive and negative tests. Currently, a lot of the revert statements are triggered in the same test that evaluate happy path logic.
Changing the test names (and add a comment for each test describing what the test does). Some of the test names are insanely long and are difficult to read.
Adding helper functions for payload generation. For example, the Bridge tests could use a method that generates a token transfer payload given some common inputs.
Write helper functions to set up certain testing scenarios rather than calling other tests internally.
Use the wormhole interfaces in the tests instead of duplicating events, and constants.
I reviewed the
ethereum
directory. The tests in this PR are meant to replicate the existing javascript tests. However, these tests need a lot of work and there should be a follow up PR that fixes these tests (and adds a more comprehensive test suite). Here is a short list of enhancements we could add to improve the test suite:Bridge
tests could use a method that generates a token transfer payload given some common inputs.Originally posted by @gator-boi in #4070 (review)
The text was updated successfully, but these errors were encountered: