Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in settings to control whether herald keeps a transactional email history #3

Open
raiderrobert opened this issue Jul 22, 2016 · 2 comments
Open

Add in settings to control whether herald keeps a transactional email history #3

raiderrobert opened this issue Jul 22, 2016 · 2 comments
Labels
enhancement

Comments

@raiderrobert
Copy link
Collaborator

No description provided.

@jproffitt
Copy link
Contributor

@raiderrobert I think a better setting would be how long it keeps transaction email history. Could be set to None of course to disable it altogether. The only question is how do we delete old history when the time passes. Do we use a celery task? Seems like a lot of overhead. Or do we just check and delete any time an email is sent? Would mean an extra query every time an email is sent.

@jproffitt
Copy link
Contributor

sorry, I realize now that #5 is talking about that very thing I said above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raiderrobert @jproffitt