Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sixtyupgrade import missing talent point #756

Closed
rdmqwerty opened this issue Jun 20, 2024 · 0 comments · Fixed by #768
Closed

sixtyupgrade import missing talent point #756

rdmqwerty opened this issue Jun 20, 2024 · 0 comments · Fixed by #768
Labels

Comments

@rdmqwerty
Copy link

Describe the bug
after doing an import from sixtyupgrades, wowsims has 1 unspent talent point. it does not match the talents from sixtyupgrades

To Reproduce
Steps to reproduce the behavior:

  1. navigate to this test character i created on sixtyupgrades - https://sixtyupgrades.com/cata/set/r2e4aBu9sMLwkvgMuaLqre
  2. Click on the export button
  3. copy to clipboard
  4. navigate to https://wowsims.github.io/cata/priest/shadow/
  5. click on import - 60U cata
  6. paste in the import string
  7. go to the talents tab of wowsims
  8. observe the discipline talent "mental agility" is only 2/3 and there is an unspent talent point

Expected behavior
i would expect the talent tree from sixtyupgrades to be replicated in wowsims

Additional context
i took a look at the json object that is exported from sixtyupgrades. there are two places that include talents. links.talents has a hyperlink to a sixtyupgrades talent calculator that includes 3/3 mental agility. there is also the talents array which includes

{
    "name": "Mental Agility",
    "id": 8595,
    "rank": 3,
    "spellId": 14781
},

i do not know which source wowsims imports talents from, but since both of these places are showing the proper rank 3 of mental agility, i theorize the issue lies within the wowsims importing logic not reading the export string correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants