Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BDK Death Strike Minimum Heal Too High #805

Closed
serrapaladin opened this issue Jun 30, 2024 · 0 comments · Fixed by #807
Closed

BDK Death Strike Minimum Heal Too High #805

serrapaladin opened this issue Jun 30, 2024 · 0 comments · Fixed by #807
Labels
bug Something isn't working Death Knight

Comments

@serrapaladin
Copy link

Describe the bug
Blood DK's Death Strike is falsely adding the modifier from Improve Death Strike onto Death Strikes that heal the minimum of 7% of max HP. This makes the minimum value it heals for about 45% too high.

To Reproduce
Steps to reproduce the behavior:

  1. In the Blood DK sim, make any encounter with 0 DTPS, for example Encounter = Default/Raid Target, Tank Assignment = None
  2. Run the sim with the standard Blood Spec.
  3. Remove the 3 points in Improved Death Strike and rerun.
  4. Compare healing done per Death Strike.

Expected behavior
In-game, it looks like the logic is: calculate DS heal including all modifiers, and if the final result is less than 7% max HP, set it to 7% max HP. That final healing amount should just be 7% of max HP, not further modified by Improved Death Strike.

Sim Links and Screenshots
image

@rosenrusinov rosenrusinov added bug Something isn't working Death Knight labels Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Death Knight
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants