Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Retribution] Tricks of the Trade not applied #860

Closed
MattZeeX opened this issue Jul 21, 2024 · 6 comments · Fixed by #890
Closed

[Retribution] Tricks of the Trade not applied #860

MattZeeX opened this issue Jul 21, 2024 · 6 comments · Fixed by #890
Assignees
Labels

Comments

@MattZeeX
Copy link

In the Ret sim, when you apply add Tricks of the trade as a Misc Raid Buff under settings, it does not actually increase the damage of the Ret pally.

With just one tricks it appears to get instantly cancelled, and when you add multiple tricks it seems like they don't all get added? Can't really see it in the timeline but under the buffs the number doesn't match the amount you selected.

To Reproduce

  1. Sim a baseline
  2. Add a tricks of the trade in the raid buffs
  3. Notice DPS doesn't change, check the timeline and see tricks of the trade immediately gets cancelled

Expected behavior
A DPS increase and tricks to last the full 6 second duration

@1337LutZ
Copy link
Contributor

1337LutZ commented Jul 22, 2024

@hillerstorm I believe this is due to the fact that the APL doesn't have this APL entry set, thus it will never cast manually controlled cooldowns.
image

It probably needs that entry, or just like Bloodlust, add Tricks to the prepull

@1337LutZ
Copy link
Contributor

@MattZeeX For now you can just add Tricks to the Default APL in the Prepull section:
image

@hillerstorm
Copy link
Contributor

hillerstorm commented Jul 22, 2024

@hillerstorm I believe this is due to the fact that the APL doesn't have this APL entry set, thus it will never cast manually controlled cooldowns. image

It probably needs that entry, or just like Bloodlust, add Tricks to the prepull

Is an If: <None> entry for auto cast needed? There's two places in the rotation where I pop them, I just don't ever want to pop trinkets "whenever possible" :D

Doing the change you suggested is a -500dps loss because it pops trinket

@1337LutZ
Copy link
Contributor

1337LutZ commented Jul 22, 2024

@hillerstorm I believe this is due to the fact that the APL doesn't have this APL entry set, thus it will never cast manually controlled cooldowns. image
It probably needs that entry, or just like Bloodlust, add Tricks to the prepull

Is an If: <None> entry for auto cast needed? There's two places in the rotation where I pop them, I just don't ever want to pop trinkets "whenever possible" :D

Doing the change you suggested is a -500dps loss because it pops trinket

Yea I noticed, I think adding it to prepull actions is best, like you did with BL, or add it to the autocast logic as a strict sequence

@1337LutZ
Copy link
Contributor

Or actually, that will only allow you to receive it once... Perhaps just add it as a first priority cast so it will always cast it on CD

@1337LutZ
Copy link
Contributor

Like this:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants