Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enchant ID for "Enchant Boots: Greater Spirit" (+18 Spirit) incorrect on sim database #1495

Closed
jd7901 opened this issue Oct 28, 2022 · 0 comments · Fixed by #1661
Closed

Comments

@jd7901
Copy link

jd7901 commented Oct 28, 2022

Describe the bug
Exporting from wowsims addon, +18 Spirit to Boots (Greater Spirit) is set up with ID 44508, but the sim is exporting it as ID 44593 (which is Enchant BRACERS: MAJOR Spirit)

To Reproduce
Steps to reproduce the behavior:

Export from wowsims addon.
Import to github
Get error
Only enchant that is missing is the boots enchant from the exported sim code

Expected behavior
Apply the "Greater Spirit" enchant to boots slot on github wotlk simulator (for warlock)

Sim Links and Screenshots

{"talents":"2350002031023510253500331151-000000000000000000000000000-55000005000000000000000000","glyphs":{"major":["Glyph of Quick Decay","Glyph of Haunt","Glyph of Life Tap"],"minor":["Glyph of Unending Breath","Glyph of Drain Soul","Glyph of Enslave Demon"]},"class":"warlock","race":"Human","name":"Seedgobrrtt","gear":{"items":[{"enchant":3820,"gems":[41285,40051],"id":39496},{"id":40071,"gems":[]},{"enchant":3810,"gems":[39998],"id":40424},{"enchant":3722,"gems":[],"id":41610},{"enchant":1144,"gems":[],"id":42102},{"enchant":2332,"gems":[],"id":39252},{"enchant":3246,"gems":[39941],"id":39500},{"id":37408,"gems":[41457]},{"enchant":3872,"gems":[39998,40051],"id":40422},{"enchant":1147,"gems":[],"id":40750},{"enchant":3840,"gems":[],"id":49123},{"enchant":3840,"gems":[],"id":40719},{"id":40682,"gems":[]},{"id":37873,"gems":[]},{"enchant":3830,"gems":[],"id":40336},{"id":40698,"gems":[]},{"id":37177,"gems":[]}]},"professions":[{"name":"Enchanting","level":445},{"name":"Tailoring","level":441}],"level":80,"spec":"","realm":"Pagle"}

Desktop (please complete the following information):

  • OS: WIN10
  • Browser: chrome
  • Version [e.g. 22]

Additional info
It doesn't look like either of the enchant IDs I posted are actually in that import script, so I have no idea where the github is pulling that info / error from

@jimmyt857 jimmyt857 linked a pull request Nov 10, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant