Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Gear/Gems Cumulative Lag #1910

Closed
blooblahguy opened this issue Nov 23, 2022 · 1 comment · Fixed by #1930
Closed

Changing Gear/Gems Cumulative Lag #1910

blooblahguy opened this issue Nov 23, 2022 · 1 comment · Fixed by #1930

Comments

@blooblahguy
Copy link

Describe the bug
Changing gems or gear slowly adds more and more lag into the sim. Switching gear or gems goes from a near instant interact to something that take 5 seconds or more,

To Reproduce
Steps to reproduce the behavior:

  1. Go to any sim gear set
  2. Click on each item and swap gems multiple times, go to the next item and repeat. Or swap items multiple times.
  3. Every change adds more and more lag to the interaction. By the time you reach the last piece changing gems takes 5+ seconds (i'm on a 5950x, I assume this is much worse for lower end cpus)

Expected behavior
The time it takes to change gear/gems remains consistent.

Desktop (please complete the following information):

  • OS: PC
  • Browser: Chrome, happens with both localhost and wowsims.github.io
  • Version 0.1.5

Additional context
Refreshing the browser resets the issue, and gem/gear go back to being a near instant interaction.

@kayla-glick
Copy link
Contributor

At a quick glance I wonder if this is because of event handlers being added and not properly cleaned up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants