Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug calculating hit #1917

Closed
Dranthax opened this issue Nov 25, 2022 · 0 comments · Fixed by #1919
Closed

Bug calculating hit #1917

Dranthax opened this issue Nov 25, 2022 · 0 comments · Fixed by #1919

Comments

@Dranthax
Copy link

Describe the bug
A clear and concise description of what the bug is.
Trying to create an estimate of a BiS list for Warlock P2, all items with hit manually added together should come to 288 equipped hit, but only comes to 270
To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error
    Just scroll over total calculated hit value vs. manually adding.
    Expected behavior
    A clear and concise description of what you expected to happen.
    Total hit should be at 288 from talents.

Sim Links and Screenshots
If applicable, add links to your sim settings or screenshots to help explain your problem.

https://wowsims.github.io/wotlk/warlock/#eJzjUuFgEmAyYLJg9GCMYCxgamBknMDIuIDxC/MGRqYDjIwXGBlfMDI6iXIwKjBpMBowWjA6MAaAVDKuYGQUYpCazdrEyBaQk1iZWsTBLsAh9YCRi1/g3gMmiTeySmxHDzHd2sHExSlw9gGTEvM+IJNf4MtzJolHQDkgDyTAI7DpCZNElyxMeucLJokfHGDpz0ABXoG2x0wSc4SUWIACDFwCAg+BqqfIKLFDtDMAdWx+wqTECeFCjNgNNKIdYQO/wHmgc6bJwAU4BbY/hjqHU+DecyiTRWD/LhB57jFIy75nTBJ9ckpstyBaGIAq3z2EqFQS4QCHQwBLBGsCUwUjMMQ6GBm1JjAxjAIUUCXAwSjAJMEUAUwqXDMYmQoYs6S4+IBiLBKwxMQETEFsEJEuRnUjY1MDAwMjA2MgYWxqaGBkChIwNjY0NDXU1TUFSRoYmBo+YpTgmNvOLHDzKZPE5adMCk2XmTT+XWIy+HuJ6QUjywdG7lmMDLcYGWYxMSjdZuIEO+VAkoMgxFF+DpKzZoLASXtLiMgFe8U0MLhmb7SaSSFYgonmcVniQA1TGk4eIWCON1XsAQFIWHUcdnCECjgkMAIAo86OSw==

Sim setup.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

-Windows 10
-Avast
-1.5

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

N/A

Additional context
Add any other context about the problem here.
Likely due to an issue with the item level changes and values not being updated properly despite having tooltips being correct

@jimmyt857 jimmyt857 linked a pull request Nov 25, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant