Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS not refunding RP on miss/dodge/parry #2086

Closed
enhancedgore opened this issue Dec 8, 2022 · 0 comments · Fixed by #2091
Closed

FS not refunding RP on miss/dodge/parry #2086

enhancedgore opened this issue Dec 8, 2022 · 0 comments · Fixed by #2091

Comments

@enhancedgore
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.
Frost Strike is not refunding runic power when it misses, dodges, or is parried.

To Reproduce
Steps to reproduce the behavior:

  1. Load up sim for Frost DK with less than 8% hit (melee)
  2. Press simulate
  3. Click Results -> Timeline
  4. Scroll sideways until you find a FS with a red border
  5. Look at the RP row

A clear and concise description of what you expected to happen.
According to wowhead's spelldata for Frost Strike, it has the "Discount Power On Miss" flag, meaning it should refund cost when it does not land.

Sim Links and Screenshots
If applicable, add links to your sim settings or screenshots to help explain your problem.

Screen Shot 2022-12-08 at 4 51 47 pm

https://wowsims.github.io/wotlk/deathknight/#eJztU0FoE0EU3fddk+02pWMPMq6NrHsQKQ3M7hiIp1099Rjw0muQSkEPSxHUgpiKgtRDepCaRvFcvArSxhYKeslBLZhWEA9SVFK0mJtBEPybBMSboN78h8+8/977w8z8sY9ZJEhRAROYRkxlYAFYBlaADWATaAEd0OmDFlxSKCBCEZOIcasrG2Gnc2P/daSKF0pXpmastLCdOuxh8fE1yd2sl3r8lF48J3tAdN6St29theyM2Fsj+S7bQ2nx6gnJr9nEwuUOWx40KGGGxDwzN494JiODYYv5O6N9mBHbdfJSvGY5mz8z+eWnOS0q6yQXR21T7D4izrdXk7xRT/Knl4ng+yrJh05/sexwvcIdhy1SQwUUzUnzcnLIsQUy/scvMTtoQZCkGDwu3zBuH64CXILk6Zjg+Sh1ZVEl4ikaMZzBAz1fO3Qxj5zyczpQKtB5pU8EgdLKD7RSSmtf+Trv5xgxr1We0w6kda9J4m6T5N4HcqtNOl7dIrW0RS2YbaRrMN7AqJHhvaeB3r7XokO1pSQa4cnezpvh0XPd2A6DdYrvX53NFEsXz05fmpo57wZ594y0/vU7t+eiv9Gm3Hj2J31UYSw+9bvi7uWVF3eivqMV8n/4AURfiwo=

144s FS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant