Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Righteous Fury #2716

Closed
konaresco opened this issue Feb 24, 2023 · 2 comments
Closed

Righteous Fury #2716

konaresco opened this issue Feb 24, 2023 · 2 comments

Comments

@konaresco
Copy link

konaresco commented Feb 24, 2023

Is your feature request related to a problem? Please describe.
I can't see Righteous Fury buff in simulation settings or results for Protection Paladin mode. Not sure if it's already calculated into sim as default or not.

Describe the solution you'd like
Adding Righteous Fury to simulation settings or if it's already there - adding visual confirmation and taking into consideration Improved Righteous Fury talent when calculating simulation outcome.

Describe alternatives you've considered

Additional context

@Watcher7
Copy link
Contributor

Watcher7 commented Apr 18, 2023

Righteous Fury is implemented as a passive stat change rather than an aura in

func (paladin *Paladin) ActivateRighteousFury() {
paladin.PseudoStats.DamageTakenMultiplier *= 1 - 0.02*float64(paladin.Talents.ImprovedRighteousFury)
paladin.OnSpellRegistered(func(spell *core.Spell) {
if spell.SpellSchool == core.SpellSchoolHoly {
spell.ThreatMultiplier *= 1.8
}
})
// Extra threat provided to all tanks on certain buff activation, for Paladins that is RF.
paladin.PseudoStats.ThreatMultiplier *= 1.43
}

Same goes for the relevant talent.

@jarveson
Copy link
Contributor

jarveson commented May 6, 2023

yeap, was implemented correct before as far as i can tell, i refactored it into a buff tho so its a least listed now for better or worse with #3045

@jarveson jarveson closed this as completed May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants