You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since this isn't filterable, REST API plugins that actually have the need to set headers are being broken by WPGraphQL JWT Auth.
I think the best action is to remove this functionality from this WPGraphQL JWT Auth plugin as I feel like we're over-reaching the responsibility of this plugin anyway.
The intent of this plugin is to handle auth for GraphQL requests. While I'm not opposed to having the JWT tokens work for REST as well, that seems like a responsibility outside the scope of this plugin.
The text was updated successfully, but these errors were encountered:
I mentioned this in a comment on #89 as well, but I've opened a PR that I believe handles this issue in a way that should prevent so much breakage because of the headers. #118
See: GoogleForCreators/web-stories-wp#2950 (comment)
The issue is here: https://github.com/wp-graphql/wp-graphql-jwt-authentication/blob/develop/src/ManageTokens.php#L337-L347
Since this isn't filterable, REST API plugins that actually have the need to set headers are being broken by WPGraphQL JWT Auth.
I think the best action is to remove this functionality from this WPGraphQL JWT Auth plugin as I feel like we're over-reaching the responsibility of this plugin anyway.
The intent of this plugin is to handle auth for GraphQL requests. While I'm not opposed to having the JWT tokens work for REST as well, that seems like a responsibility outside the scope of this plugin.
The text was updated successfully, but these errors were encountered: