Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support galleries, or comma-separated lists of IDs #283

Closed
mattheu opened this issue Apr 21, 2015 · 9 comments
Closed

Support galleries, or comma-separated lists of IDs #283

mattheu opened this issue Apr 21, 2015 · 9 comments
Milestone

Comments

@mattheu
Copy link
Contributor

mattheu commented Apr 21, 2015

The Attachment field should support galleries. Allowing you to add multiple files which will be stored as a comma separated list.

@mattheu
Copy link
Contributor Author

mattheu commented Apr 21, 2015

From #123

@mattheu mattheu added this to the v0.4.0 milestone Apr 21, 2015
@danielbachhuber danielbachhuber changed the title Gallery Support galleries, or comma-separated lists of IDs Apr 21, 2015
@StaggerLeee
Copy link

Would it be possible to use Shortcake to make something like Flexslider gallery from gallery shortcode (not attached to post only) ?
I did managed it manually, but as an addon for Shortcake it would be great.

http://webdesignforidiots.net/2015/02/customizing-the-output-of-the-gallery-shortcode/

@danielbachhuber
Copy link
Contributor

Would it be possible to use Shortcake to make something like Flexslider gallery from gallery shortcode (not attached to post only) ?

Nope, that looks to be separate from Shortcake.

@StaggerLeee
Copy link

Thanks for reply. Wanted just to see how easy would be to bring WordPress closer to news portals. Native gallery is big NO-NO for news portals and magazine layouts.

@mattheu
Copy link
Contributor Author

mattheu commented May 13, 2015

Would like to support adding multiple images with the image field, but would be up to the implementor to actually build the gallery.

@StaggerLeee
Copy link

Oh no, you missed it. Dont ask you to make this form URL above. Just to make it possible for users to make it.
All Shortcake needs to do is visualize slider in TinyMce body. And of course on click at shortcode add, sort, remove images, but this is more WP native modal window and gallery management, nothing special new needs.

And more important. This from URL above is piece of cake to make manualy.
Most important would be Shortcake keep native [gallery id=""] shortcode for future change of mind, future developing, etc.

@StaggerLeee
Copy link

Just to say. I did not tested code form URL above and dont know if it works. It is just there for reference, because I cannot find anymore on Google right URL where I found code and used it.
Have it in my snippets collections, but there is no need to paste it here and spam with it.

But principle is the same.
WP native gallery shortcode stays the same in database, not strange shortcodes different plugins output and when you delete plugin you are in big troubles. [my-fancy-gallery id=""].

@cliffordp
Copy link

I know it's not ideal, but if you just HAVE to have a comma-separated list of attachment IDs, you can use the post_select field type (but then there's no image preview). For example:

        $postid_query_args = array(
            'post_status' => array( 'inherit' ),
            'post_type' => 'attachment', // default is 'post'
        );
...
...
                array(
                    'label'  => esc_html__( 'Attachment(s) to display', '' ),
                    'attr'   => 'postid',
                    'query'  => $postid_query_args,
                    'type'   => 'post_select',
                    'multiple' => true, // allow user to select more than 1 post
                    'description'  => esc_html__( 'Drop down list is all files from the Media Library. This shortcode argument can accept one or more comma-separated post/attachment IDs.', '' ),
                ),

@danielbachhuber danielbachhuber removed this from the v0.5.0 milestone Aug 13, 2015
@danielbachhuber danielbachhuber added this to the v0.7.0 milestone Oct 26, 2015
@goldenapples
Copy link
Contributor

Done in #508.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants