Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update compatibility with new filter when #344 completes. #359

Closed
alimuzzaman opened this issue Feb 27, 2019 · 5 comments
Closed

Update compatibility with new filter when #344 completes. #359

alimuzzaman opened this issue Feb 27, 2019 · 5 comments
Assignees
@alimuzzaman
Labels
type/enhancement
Milestone
v2.2.4

Comments

@alimuzzaman
Copy link
Contributor

alimuzzaman commented Feb 27, 2019 •
edited
Loading

Imagify and Smush compatibility need to be updated with the new filter (wp_stateless_skip_add_media) added in #344.
@alimuzzaman alimuzzaman self-assigned this Feb 27, 2019
@antonkorotkov
Copy link
Contributor

Is it something you would do in 2.2.4 milestone?

@alimuzzaman alimuzzaman added this to the v2.2.4 milestone Feb 28, 2019
@alimuzzaman
Copy link
Contributor Author

Yes, simple changes.

alimuzzaman pushed a commit that referenced this issue Feb 28, 2019
Using wp_stateless_skip_add_media filter
4b84298 
Related issue #359
alimuzzaman pushed a commit that referenced this issue Feb 28, 2019
Update imagify.php
665fec0 
Related issue #359
@alimuzzaman
Copy link
Contributor Author

@antonkorotkov you can review now.

@antonkorotkov
Copy link
Contributor

@alimuzzaman just to clarify - before you added this new filter you were using remove_filter in order to disable sync in different conditions. And now you did the same but using the newly created filter, right?

@alimuzzaman
Copy link
Contributor Author

@antonkorotkov
Yes, disabled sync when the attachment is supported for optimization.

@alimuzzaman alimuzzaman mentioned this issue Mar 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alimuzzaman alimuzzaman

Labels
type/enhancement
Projects
None yet
Milestone
v2.2.4
Development

No branches or pull requests
3 participants
@antonkorotkov @ewsopp @alimuzzaman