Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a template for the Learn Type page #10

Open
JulieKuehl opened this issue May 30, 2019 · 5 comments
Open

Create a template for the Learn Type page #10

JulieKuehl opened this issue May 30, 2019 · 5 comments
Assignees

Comments

@JulieKuehl
Copy link
Member

JulieKuehl commented May 30, 2019

Create the template based on the designs here: https://wp.invisionapp.com/share/BNP0V7QXRF8#/screens/345929281

Beta working site: https://learnwp.jco.dev
(any changes merged into this repo will appear here within 5 minutes of merging)

@JulieKuehl JulieKuehl added the help wanted Extra attention is needed label May 30, 2019
@man4toman
Copy link
Member

@JulieKuehl
Please assign me on this :)

@JulieKuehl JulieKuehl added this to the Learn site beta v 1.0 milestone May 31, 2019
@JulieKuehl JulieKuehl removed the help wanted Extra attention is needed label May 31, 2019
@JulieKuehl
Copy link
Member Author

@man4toman Done! Thank you!

@man4toman
Copy link
Member

man4toman commented Jun 12, 2019

I create #19 for this issue.

But there is some questions like, where can I find the font sizes, padding and margins from designs?
Should we stay loyal to the size? Or should we work according to the current codes and the intervals defined in the original style.css file?

@JulieKuehl
Copy link
Member Author

@iamchetanp can you answer these questions?

@man4toman
Copy link
Member

man4toman commented Jun 17, 2019

@JulieKuehl
It's done, based on #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants