Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read instance for LogFloat #5

Closed
zaxtax opened this issue Jun 2, 2017 · 5 comments
Closed

Read instance for LogFloat #5

zaxtax opened this issue Jun 2, 2017 · 5 comments
Assignees
@wrengr

Comments

@zaxtax
Copy link

zaxtax commented Jun 2, 2017

It would be nice if there was a Read instance for LogFloat. As a first pass I have the following:

instance Read LogFloat where
    readsPrec p s = [(logFloat x, r) | (x, r) <- readsPrec p s]
@wrengr wrengr self-assigned this Jun 19, 2017
@wrengr
Copy link
Owner

wrengr commented Jun 19, 2017

I just pushed 5f51503 which does this more safely (i.e., without logFloat throwing an error). Test it out and make sure it works for you, then I'll publish it to Hackage

@zaxtax
Copy link
Author

zaxtax commented Jun 19, 2017

Works for me!

@wrengr wrengr closed this as completed Jun 19, 2017
@wrengr
Copy link
Owner

wrengr commented Jun 19, 2017

FWIW, I'm going to try to get the Vector instances put in before I publish it. Feel free to harass me if it's not done by next weekend.

@zaxtax
Copy link
Author

zaxtax commented Jun 19, 2017 •
edited
Loading

Interesting. What made you decide to include them?

@zaxtax
Copy link
Author

zaxtax commented Jul 5, 2017

Is the Vector instance stuff happening?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wrengr wrengr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zaxtax @wrengr