Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement request: Build a Directed Acyclic Graph #4

Open
ivan-marroquin opened this issue May 13, 2022 · 3 comments
Open

Enhancement request: Build a Directed Acyclic Graph #4

ivan-marroquin opened this issue May 13, 2022 · 3 comments

Comments

@ivan-marroquin
Copy link

Hi,

Many thanks for making available this package!

I read with great interest the documentation of pyCausalFS package. I was wondering if in addition to returning the Parents and Children of MB, these algorithms also return the Spouses.

Thus, I would like to submit the following enhancements that I believe can help to facilitate the interpretation of the Markov Blanket:

  • Be able to recognize from selected features which ones are either Parents, Children, or Spouses.
  • Have a functionality to build a Directed Acyclic Graph (as shown in this R package https://github.com/malcolmbarrett/ggdag)
    In the Directed Acyclic Graph, the nodes corresponding to Parents have a specific color, which in turn it is different to the color assigned to either Children or Spouses. The remaining of features not belonging to Markov Blanket, their nodes are plotted without color.

Kind regards,

Ivan

@wt-hu
Copy link
Owner

wt-hu commented May 17, 2022

Hi
I'm glad you to enhance the package, and I also hope that you can join the project,as a collaborator.
I've invited you to be a collaborator.
Kind regards,
Wentao Hu

@wt-hu wt-hu closed this as completed May 17, 2022
@wt-hu wt-hu reopened this May 17, 2022
@wt-hu
Copy link
Owner

wt-hu commented May 17, 2022

By the way, your suggestion is very good,I agree with your enhancements.

@ivan-marroquin
Copy link
Author

Hi Wentao Hu,

Many thanks for inviting me to be a collaborator in your project. I believe that this package toyplot can be helpful, see this example:
https://toyplot.readthedocs.io/en/stable/graph-visualization.html

I installed on my windows machine. I have some issues with running the package. Perhaps, you could give a try and let me know.

Ivan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants