-
-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build failed in Windows #1574
Labels
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What's broken?
cmdrunner
Module usessyscall.SIGWINCH
which is undefined for Windows-Reference commit which triggered this behavior: commit/c7ac2be510d28d572fb10c6b9ccc2319a85c49fc
Additional Information
From what I've found googling,
syscall.SIGWINCH
is Unix/Linux specific and has no equivalent replacement in Windows. For now, build directive can be added to compile on Windows and panic on runtime when/if the module is used.Here is an example: https://github.com/cloudfoundry/cli/tree/v7.1.0/util/clissh/sigwinch
About SIGWINCH: GNU Manual
Here is the commit that I'v made on my repository to make it work: commit/5c16134f65ae41d7968038ec0463137ddde56178
If this is acceptable, I can create a pull request for this commit only.
The text was updated successfully, but these errors were encountered: