-
-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PiHole module does not use auth token to get status #1615
Labels
Comments
Cool |
Apologies for the delay in responding, and thanks for the PR! I'll take a look and hopefully get it in. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey, first of all, I'd like to say I'm super grateful for this repo to exist. I've been setting it up this morning and it's just awesome.
While setting up the pihole module, I noticed that the status does not show up. Basically, there is an unmarshal error when decoding the json.
Upon more investigation, I noticed that the requests is returning a HTTP 200, but the body is an empty json array.
The other requests (top clients and top domains) made by wtfutil to PiHole are working as expected and return expected values.
I'm happy to provide a PR with the fix.
What's broken?
The pihole module does not send the auth token when fetching the pihole server status. This results in a HTTP 200 response with empty array body. The pihole module tries to unmarshal it, but is ultimately unsuccessful
The text was updated successfully, but these errors were encountered: