Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic authentication support for RSS feed reader #957

Closed
atgreen opened this issue Aug 23, 2020 · 6 comments
Closed

Add basic authentication support for RSS feed reader #957

atgreen opened this issue Aug 23, 2020 · 6 comments
Labels
💥 feature "Good luck, you're gonna need it." wontfix

Comments

@atgreen
Copy link

atgreen commented Aug 23, 2020

What should it do?

From what I can tell, the feed parser can only read public feeds. Please consider adding support basic authentication support for private feeds.

@senorprogrammer senorprogrammer added the 💥 feature "Good luck, you're gonna need it." label Aug 28, 2020
@FliegendeWurst
Copy link

It is already possible to specify the username and password like this: https://username:password@example.com/feed.rss

@senorprogrammer
Copy link
Collaborator

@atgreen Does this solution work for you?

@ResamVi
Copy link
Contributor

ResamVi commented Oct 9, 2021

Hi, I'm looking around for hacktoberfest.
Adding username and password to the URL does do the trick, I've just tried it in a test.

Would it be useful if username+password attributes were added to the module?
That would be the solution a single private feed (multiple feeds with different credentials would require a bit more)

@senorprogrammer
Copy link
Collaborator

I think extending the module config to support those values, and being able to use them if they're both supplied in the feed URL or in the configuration would be a great improvement.

@senorprogrammer
Copy link
Collaborator

For that, might want to change the config format from a list to a map. We'd still need to support both for backwards compatibility (we do this in a number of places, try parsing one type first, if that fails, fall back to the default type and try again).

@stale
Copy link

stale bot commented Jan 11, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 11, 2022
@stale stale bot closed this as completed Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💥 feature "Good luck, you're gonna need it." wontfix
Development

No branches or pull requests

4 participants