Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offsetHeight instead of clientHeight #2

Closed
Frozzy6 opened this issue May 13, 2019 · 3 comments
Closed

offsetHeight instead of clientHeight #2

Frozzy6 opened this issue May 13, 2019 · 3 comments

Comments

@Frozzy6
Copy link
Contributor

Frozzy6 commented May 13, 2019

Hey, I found that when I'm using some elements with border table size less then clientHeight + border.
But if replace to offsetHeight everything is good.

this.collect_h_tr(this.props.children[0]!.props!.index, this.inst.current.clientHeight);

this.collect_h_tr(this.props.children[0]!.props!.index, this.inst.current.clientHeight);

@Frozzy6 Frozzy6 changed the title offsetHeight inteadof clientHeight offsetHeight instead of clientHeight May 13, 2019
@wubostc
Copy link
Owner

wubostc commented May 14, 2019

thanks @Frozzy6 , i have published to npm repository, please update to enjoy!

@wubostc wubostc closed this as completed May 14, 2019
@Frozzy6
Copy link
Contributor Author

Frozzy6 commented May 14, 2019

@wubostc Thanks you for such fast answer!

It doesn't work as well with clientHeight as with offsetHeight

image

there is an example jsfiddle about difference

@Frozzy6
Copy link
Contributor Author

Frozzy6 commented May 14, 2019

That's a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants