Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New server response format when not 200 code in playground looks unreadable #1185

Closed
flymedllva opened this issue Sep 18, 2024 · 4 comments · Fixed by #1302
Closed

New server response format when not 200 code in playground looks unreadable #1185

flymedllva opened this issue Sep 18, 2024 · 4 comments · Fixed by #1302
Labels
enhancement New feature or request internally-reviewed The issue has been reviewed internally.

Comments

@flymedllva
Copy link
Contributor

flymedllva commented Sep 18, 2024

Component(s)

studio

Is your feature request related to a problem? Please describe.

I extremely dislike the way it now shows responses not having a 200 code

Screenshot 2024-09-18 at 12 24 37
  1. it's unreadable, although the idea to show what came over HTTP is understandable, but it's better to add some custom fields to the standard GraphQL response structure. Now I don't understand how to try to read responseBody during debugging, and other fields don't give useful load
  2. We subgraphs return 4** error codes in case of non-significant problems, 5** in case of unknown server errors. At the same time they describe the standard GraphQL response structure, deviations from this logic are possible only in case of some serious problems, but it seems Playground should be used mainly for debugging, why should I deviate from this structure trying to invent another one?

Describe the solution you'd like

  • Return to the old format
  • Extend the standard GraphQL answer with fields that you think should be useful for non-200 codes
  • Do not change the structure of the response display for non-200 codes

Describe alternatives you've considered

No response

Additional context

No response

@flymedllva flymedllva added the enhancement New feature or request label Sep 18, 2024
Copy link

WunderGraph commits fully to Open Source and we want to make sure that we can help you as fast as possible.
The roadmap is driven by our customers and we have to prioritize issues that are important to them.
You can influence the priority by becoming a customer. Please contact us here.

@thisisnithin
Copy link
Member

Hi @flymedllva . As we cover more use cases we update the ui accordingly. We have an idea on how this can be improved. Thanks for the insight.

@jensneuse jensneuse added the internally-reviewed The issue has been reviewed internally. label Oct 1, 2024
@flymedllva
Copy link
Contributor Author

Hi! @thisisnithin
Is there no information on what this will look like in the future? Is it possible at least for 4** response codes not to change the GraphQL structure of the response?

@thisisnithin
Copy link
Member

Hi, this is in progress as part of a bigger PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internally-reviewed The issue has been reviewed internally.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants