fix(ws): deadlock on unsubscribe when epoll disabled #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Aenimus
reviewed
Nov 16, 2024
v2/pkg/engine/datasource/graphql_datasource/graphql_subscription_client.go
Show resolved
Hide resolved
jensneuse
approved these changes
Nov 16, 2024
StarpTech
deleted the
dustin/eng-5973-websocket-deadlock-on-reconnect-when-epoll-is-disabled
branch
StarpTech
pushed a commit
that referenced
this pull request
Nov 16, 2024
🤖 I have created a release *beep* *boop* --- ## [2.0.0-rc.124](v2.0.0-rc.123...v2.0.0-rc.124) (2024-11-16) ### Bug Fixes * **ws:** deadlock on unsubscribe when epoll disabled ([#982](#982)) ([2fad683](2fad683)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have used the unsubscription channel of the epoll implementation for both paths, although epoll can be disabled. This led to a deadlock.
Related Cosmo PR: wundergraph/cosmo#1380