Skip to content

Commit 49965e7

Browse files
committed
fix: Fix config hook implementations for vite plugins
Turns out the returned config is merged with the user config, so we don't have to do that ourselves.
1 parent fa2b656 commit 49965e7

File tree

2 files changed

+19
-21
lines changed

2 files changed

+19
-21
lines changed

src/core/vite-plugins/devHtmlPrerender.ts

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,20 +11,17 @@ export function devHtmlPrerender(config: InternalConfig): vite.Plugin {
1111
return {
1212
apply: 'build',
1313
name: 'wxt:dev-html-prerender',
14-
config(userConfig) {
15-
return vite.mergeConfig(
16-
{
17-
resolve: {
18-
alias: {
19-
'@wxt/reload-html': resolve(
20-
config.root,
21-
'node_modules/wxt/dist/virtual-modules/reload-html.js',
22-
),
23-
},
14+
config() {
15+
return {
16+
resolve: {
17+
alias: {
18+
'@wxt/reload-html': resolve(
19+
config.root,
20+
'node_modules/wxt/dist/virtual-modules/reload-html.js',
21+
),
2422
},
2523
},
26-
userConfig,
27-
);
24+
};
2825
},
2926
async transform(html, id) {
3027
const server = config.server;

src/core/vite-plugins/devServerGlobals.ts

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,19 @@ import { InternalConfig } from '../types';
77
export function devServerGlobals(internalConfig: InternalConfig): Plugin {
88
return {
99
name: 'wxt:dev-server-globals',
10-
config(config) {
10+
config() {
1111
if (internalConfig.server == null || internalConfig.command == 'build')
1212
return;
1313

14-
config.define ??= {};
15-
config.define.__DEV_SERVER_PROTOCOL__ = JSON.stringify('ws:');
16-
config.define.__DEV_SERVER_HOSTNAME__ = JSON.stringify(
17-
internalConfig.server.hostname,
18-
);
19-
config.define.__DEV_SERVER_PORT__ = JSON.stringify(
20-
internalConfig.server.port,
21-
);
14+
return {
15+
define: {
16+
__DEV_SERVER_PROTOCOL__: JSON.stringify('ws:'),
17+
__DEV_SERVER_HOSTNAME__: JSON.stringify(
18+
internalConfig.server.hostname,
19+
),
20+
__DEV_SERVER_PORT__: JSON.stringify(internalConfig.server.port),
21+
},
22+
};
2223
},
2324
};
2425
}

0 commit comments

Comments
 (0)