Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: Change suffix to use ES6 default module export #1315

Merged
merged 1 commit into from
Feb 24, 2017
Merged

parser: Change suffix to use ES6 default module export #1315

merged 1 commit into from
Feb 24, 2017

Conversation

Turbo87
Copy link
Contributor

@Turbo87 Turbo87 commented Feb 23, 2017

This export will be transpiled by Babel for the cjs distribution, but will enable others to use a pure ES6 module distribution.

Resolves #1313

/cc @chadhietala @mmun

@chadhietala
Copy link

This seems good. I wouldn't think the CI failures are related.

@Turbo87
Copy link
Contributor Author

Turbo87 commented Feb 23, 2017

yeah, that test failure seems to be unrelated

@nknapp
Copy link
Collaborator

nknapp commented Feb 23, 2017

It's not completely unrelated. The reason is this:

ERROR: Coverage for statements (95.06%) does not meet global threshold (100%)
ERROR: Coverage for branches (95.77%) does not meet global threshold (100%)
ERROR: Coverage for functions (97.01%) does not meet global threshold (100%)

The generated file dist/cjs/handlebars/compiler/parser.js is not completely covered by tests.
There is a line /* istanbul ignore next */ in the header but somehow it has no effect, when this PR is applied.

@nknapp
Copy link
Collaborator

nknapp commented Feb 23, 2017

Coverage-Report of the parser.js file...

parser-coverage.zip

@nknapp
Copy link
Collaborator

nknapp commented Feb 23, 2017 •
edited
Loading

Since all the lines in this file have been ignored in the recent builds and I don't think it is possible to cover the entire file, I think it would be OK to exclude the file in .istanbul.yml.

@chadhietala could you do that?

@Turbo87
Copy link
Contributor Author

Turbo87 commented Feb 23, 2017

@nknapp good point. I've added the parser.js file to the istanbul ignore list

@Turbo87 @nknapp
Parser: Change suffix to use ES6 default module export
508347e 
- This export will be transpiled by Babel for the cjs distribution,
  but will enable others to  use a pure ES6 module distribution
- Instanbul: Ignore "parser.js" for coverage reporting. This file was ignored before
  via annotation, but this has no effect anymore due to the above change
- Remove istanbul annotation from `parser-prefix` (@nknapp)

Squashed by @nknapp
@nknapp
Copy link
Collaborator

nknapp commented Feb 24, 2017

I have squashed the commits (makes it easier to cherry-pick to the 4.x-branch) and removed the now obsolete istanbul annotation from parser-prefix.

I hope you didn't mind me force-pushing to your es6-parser branch.

@nknapp nknapp merged commit 8baba76 into handlebars-lang:master Feb 24, 2017
@nknapp nknapp mentioned this pull request Feb 24, 2017
Closed
@Turbo87
Copy link
Contributor Author

Turbo87 commented Feb 24, 2017

Not at all, thanks!

@renovate-bot renovate-bot mentioned this pull request Apr 29, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Turbo87 @chadhietala @nknapp