-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wp_localize_script variable lost in minification #28
Comments
At first sight, I'm seeing:
|
Yes I'm convinced now handle extra data processing is broken when two scripts from a single group include extra data. Only the last one is added by wpdm. Seeing if I can patch this. |
lkraav
pushed a commit
to lkraav/wp-dependency-minification
that referenced
this issue
Aug 29, 2013
I believe this is the same issue which was reported at http://wordpress.org/support/topic/jqueryjs-generated-css-error |
shadyvb
pushed a commit
to shadyvb/wp-dependency-minification
that referenced
this issue
Sep 9, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm seeing a variable getting lost (no "/* wp_localize_script($data_handle): */\n" visible in the source, while some others are) and it's killing the whole page's JS.
Investigating further. Opening the issue for some possible early feedback from core devs if this should even be possible, so I'm not chasing ghosts.
The text was updated successfully, but these errors were encountered: