-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widget Activities in Inactive Widgets area #283
Comments
@desaiuditd Nice catch! We definitely need to track updates to widgets wherever they may be. However i'm not sure if we really need to track sorting of inactive widgets, doesn't make much sense to me. @fjarrett Thoughts ? |
Yeah, probably no need to track sorting of inactive widgets. It's really just a trash area for widget instances. |
@shadyvb @westonruter Why not? I mean, it's a WordPress change so shouldn't Stream be tracking every single thing that is changed, be it big or small? With the changes coming in #251 people can easily opt-out of tracking whatever they think is unnecessary in their opinion. Inactive widget order is not a user-specific order (like reordering metaboxes or something) it is an order that affects all users on that screen. Correct me if I'm wrong about this. Maybe some more deep thought/discussion should be done about where exactly we draw the line for Stream, what it should track, and what it should not track. |
Correct. Inactive widget order is not user-specific. All users would see the same. |
@fjarrett I do not think a user would be able to ignore this type of action, since he'd need to disable all |
@shadyvb Yes, that's certainly the counter-argument here, and it's definitely a valid one. But to answer your question, they could just by excluding the "Inactive Sidebar" context. |
Yea! didn't think of that. If they can filter/exclude it, then it'd only be natural to track everything and have users filter out what they do not want. |
👍 to @fjarrett |
@desaiuditd You are clear to go ahead and proceed with this issue! And thanks for reporting it. /five |
It seems that Stream is not able to log widget activities/changes from the Inactive Widgets area. Following two use cases are not being tracked down:
"Widget is deleted from Inactive Area" is already handled in #282
The text was updated successfully, but these errors were encountered: