You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think it should check that the tag name github.event.release.tag_name should be compared to the package version, in addition to the name. I also think the release name should only have to start with the version number
I would put this check in a .js file. My view is that as much as is possible Github Actions should just call script files
These are much easier to test locally without change/commit/push/release cycles
It is harder to read login in .yml files
It would be more portable to other 'forges' like GitLab in the future
If e.g. Github Actions is down you can manually deploy.
In this case it would stop us having to call an external action, as reading from package.json is easy in javascript. So I would set this up as the prepublishOnly script in npm/package.json, if the environment variables for the release name/tag are missing it should print a message to console (in case someone runs it manually, telling them to see the docs for publishing using a github release).
The text was updated successfully, but these errors were encountered:
github.event.release.tag_name
should be compared to the package version, in addition to the name. I also think the release name should only have to start with the version numberI would put this check in a .js file. My view is that as much as is possible Github Actions should just call script files
In this case it would stop us having to call an external action, as reading from
package.json
is easy in javascript. So I would set this up as theprepublishOnly
script in npm/package.json, if the environment variables for the release name/tag are missing it should print a message to console (in case someone runs it manually, telling them to see the docs for publishing using a github release).The text was updated successfully, but these errors were encountered: