Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve publish action #4

Open
gilbertbw opened this issue Nov 8, 2023 · 0 comments
Open

Improve publish action #4

gilbertbw opened this issue Nov 8, 2023 · 0 comments
Assignees

Comments

@gilbertbw
Copy link
Contributor

  • I think it should check that the tag name github.event.release.tag_name should be compared to the package version, in addition to the name. I also think the release name should only have to start with the version number

I would put this check in a .js file. My view is that as much as is possible Github Actions should just call script files

  • These are much easier to test locally without change/commit/push/release cycles
  • It is harder to read login in .yml files
  • It would be more portable to other 'forges' like GitLab in the future
  • If e.g. Github Actions is down you can manually deploy.

In this case it would stop us having to call an external action, as reading from package.json is easy in javascript. So I would set this up as the prepublishOnly script in npm/package.json, if the environment variables for the release name/tag are missing it should print a message to console (in case someone runs it manually, telling them to see the docs for publishing using a github release).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants